!5317itz/review-policy-codeowners → develop0f5e58ae5d

Root CODEOWNERS: 3 approvals on Core paths, default MR template

AI-generatedEverything on this page was written by an AI agent from the diff: the summaries, the narration, the diagrams, the flags and the glossary. It can be wrong or incomplete, so check it against the code before you rely on it.

3commits
3files
57lines changed
36lines to read
3Core approvals
16exclusions
0consensus code changed

Where the diff is

Read these2 files · 36 lines

CODEOWNERS+29 −0.gitlab/CODEOWNERS+0 −7

Tests0 files · 0 lines

none

Which rule a path falls under

Every path is Core unless excluded; Wasm paths need both sections.

Changed pathany file in the MRWasm Permissions [2]Core [3] *7 humans + huginn-bot! exclusionsdocs, test, some tools → dev-team 2Merge needs everysection that matched satisfied
newchanged

3-minute explainer

What changed

File moves to the root

Wasm section carried over unchanged; Core section added.

.gitlab/CODEOWNERS/CODEOWNERS

Core needs three owners

Catch-all star: every path, including new directories.

7 humanshuginn-bot3 of 8

What stays out of Core

16 exclusions; thorscan and analyze moved back to Core.

/docs/7 tools7 root files/test/**

The test line needs a check

Matches 0 or 857 files, depending on how GitLab reads it.

non-recursive: 0 recursive: 857

What the diff can't show

Enforcement and owner eligibility live in project settings.

  • Code owner approval on the branch
  • All 8 owners eligible

Default MR template

Asks for pasted output; nothing in CI enforces it.

What and whySelf-verificationRiskRollout

Look here first

!/test/** matches nothing or everythingNo tracked file sits directly in test/. Non-recursive: no-op. Recursive: 857 files drop to 2. GitLab docs don't define this form.CODEOWNERS:15 ↗verify
6+/common/wasmpermissions/ @NoahSaso @codehans @zefiro576 @snoyberg
7+
8+# Every path needs 3 approvals from 3 different owners listed here, except the
9+# exclusions below. huginn-bot is one owner, so that is at least 2 humans.
10+# New paths are covered automatically. Excluded paths keep the dev-team rule
11+# (2 approvals). Editing this file is itself a [Core] change.
12+[Core][3] @son-of-odin @zlyzol @ahdzib @Bitol @starsquid @asaf45 @pratikasr @huginn-bot
13+*
14+!/docs/
15+!/test/**
16+!/tools/ci-health/
17+!/tools/events/
18+!/tools/mimir-ids/
19+!/tools/p2p-check/
20+!/tools/perf/
21+!/tools/pubkey2address/
22+!/tools/stagenet/
23+!/.editorconfig
24+!/.gitignore
25+!/.isort.cfg
26+!/LICENSE
27+!/README.md
28+!/bugbounty.md
Enforcement depends on branch settingsSection blocks merges only where code owner approval is required. Settings are applied separately; not confirmable from the repo.CODEOWNERS:12 ↗verify
3+# docs/CODEOWNERS and .gitlab/CODEOWNERS.
4+
5+[Wasm Permissions][2]
6+/common/wasmpermissions/ @NoahSaso @codehans @zefiro576 @snoyberg
7+
8+# Every path needs 3 approvals from 3 different owners listed here, except the
9+# exclusions below. huginn-bot is one owner, so that is at least 2 humans.
10+# New paths are covered automatically. Excluded paths keep the dev-team rule
11+# (2 approvals). Editing this file is itself a [Core] change.
12+[Core][3] @son-of-odin @zlyzol @ahdzib @Bitol @starsquid @asaf45 @pratikasr @huginn-bot
13+*
14+!/docs/
15+!/test/**
16+!/tools/ci-health/
17+!/tools/events/
18+!/tools/mimir-ids/
19+!/tools/p2p-check/
20+!/tools/perf/
21+!/tools/pubkey2address/
22+!/tools/stagenet/
23+!/.editorconfig
24+!/.gitignore
25+!/.isort.cfg
tools/events excluded but shipped by CIbuild-events pushes its own image each build; the head commit kept shipped tools in Core. Decide if this exclusion stands.CODEOWNERS:17 ↗verify
8+# Every path needs 3 approvals from 3 different owners listed here, except the
9+# exclusions below. huginn-bot is one owner, so that is at least 2 humans.
10+# New paths are covered automatically. Excluded paths keep the dev-team rule
11+# (2 approvals). Editing this file is itself a [Core] change.
12+[Core][3] @son-of-odin @zlyzol @ahdzib @Bitol @starsquid @asaf45 @pratikasr @huginn-bot
13+*
14+!/docs/
15+!/test/**
16+!/tools/ci-health/
17+!/tools/events/
18+!/tools/mimir-ids/
19+!/tools/p2p-check/
20+!/tools/perf/
21+!/tools/pubkey2address/
22+!/tools/stagenet/
23+!/.editorconfig
24+!/.gitignore
25+!/.isort.cfg
26+!/LICENSE
27+!/README.md
28+!/bugbounty.md
29+!/spec.md
MR description is older than the fileDescription still lists tools/analyze and tools/thorscan as excluded and /docs/**; head dropped both and uses /docs/.CODEOWNERS:16 ↗careful
7+
8+# Every path needs 3 approvals from 3 different owners listed here, except the
9+# exclusions below. huginn-bot is one owner, so that is at least 2 humans.
10+# New paths are covered automatically. Excluded paths keep the dev-team rule
11+# (2 approvals). Editing this file is itself a [Core] change.
12+[Core][3] @son-of-odin @zlyzol @ahdzib @Bitol @starsquid @asaf45 @pratikasr @huginn-bot
13+*
14+!/docs/
15+!/test/**
16+!/tools/ci-health/
17+!/tools/events/
18+!/tools/mimir-ids/
19+!/tools/p2p-check/
20+!/tools/perf/
21+!/tools/pubkey2address/
22+!/tools/stagenet/
23+!/.editorconfig
24+!/.gitignore
25+!/.isort.cfg
26+!/LICENSE
27+!/README.md
28+!/bugbounty.md
29+!/spec.md
huginn-bot counts as one Core ownerThree approvals means at least two humans; an MR huginn marks incomplete needs three. Account access not confirmable here.CODEOWNERS:12 ↗careful
3+# docs/CODEOWNERS and .gitlab/CODEOWNERS.
4+
5+[Wasm Permissions][2]
6+/common/wasmpermissions/ @NoahSaso @codehans @zefiro576 @snoyberg
7+
8+# Every path needs 3 approvals from 3 different owners listed here, except the
9+# exclusions below. huginn-bot is one owner, so that is at least 2 humans.
10+# New paths are covered automatically. Excluded paths keep the dev-team rule
11+# (2 approvals). Editing this file is itself a [Core] change.
12+[Core][3] @son-of-odin @zlyzol @ahdzib @Bitol @starsquid @asaf45 @pratikasr @huginn-bot
13+*
14+!/docs/
15+!/test/**
16+!/tools/ci-health/
17+!/tools/events/
18+!/tools/mimir-ids/
19+!/tools/p2p-check/
20+!/tools/perf/
21+!/tools/pubkey2address/
22+!/tools/stagenet/
23+!/.editorconfig
24+!/.gitignore
25+!/.isort.cfg
Exclusions need GitLab 17.11 PremiumPer GitLab docs. Instance tier isn't visible from the repo; the description's docs/ panel check confirms it works.CODEOWNERS:14 ↗look
5+[Wasm Permissions][2]
6+/common/wasmpermissions/ @NoahSaso @codehans @zefiro576 @snoyberg
7+
8+# Every path needs 3 approvals from 3 different owners listed here, except the
9+# exclusions below. huginn-bot is one owner, so that is at least 2 humans.
10+# New paths are covered automatically. Excluded paths keep the dev-team rule
11+# (2 approvals). Editing this file is itself a [Core] change.
12+[Core][3] @son-of-odin @zlyzol @ahdzib @Bitol @starsquid @asaf45 @pratikasr @huginn-bot
13+*
14+!/docs/
15+!/test/**
16+!/tools/ci-health/
17+!/tools/events/
18+!/tools/mimir-ids/
19+!/tools/p2p-check/
20+!/tools/perf/
21+!/tools/pubkey2address/
22+!/tools/stagenet/
23+!/.editorconfig
24+!/.gitignore
25+!/.isort.cfg
26+!/LICENSE
27+!/README.md
Wasm paths now need both sectionscommon/wasmpermissions/ matches Wasm [2] and Core [3]; GitLab docs say each section enforces separately.CODEOWNERS:6 ↗look
1+# Documentation: https://docs.gitlab.com/user/project/codeowners/
2+# This is the only CODEOWNERS file. GitLab reads /CODEOWNERS before
3+# docs/CODEOWNERS and .gitlab/CODEOWNERS.
4+
5+[Wasm Permissions][2]
6+/common/wasmpermissions/ @NoahSaso @codehans @zefiro576 @snoyberg
7+
8+# Every path needs 3 approvals from 3 different owners listed here, except the
9+# exclusions below. huginn-bot is one owner, so that is at least 2 humans.
10+# New paths are covered automatically. Excluded paths keep the dev-team rule
11+# (2 approvals). Editing this file is itself a [Core] change.
12+[Core][3] @son-of-odin @zlyzol @ahdzib @Bitol @starsquid @asaf45 @pratikasr @huginn-bot
13+*
14+!/docs/
15+!/test/**
16+!/tools/ci-health/
17+!/tools/events/
18+!/tools/mimir-ids/
19+!/tools/p2p-check/
Self-verification is text onlyThe template asks for pasted output; no CI job in this diff checks it.Default.md:7 ↗look
1+# Merge request
2+
3+## What and why
4+
5+## Self-verification
6+
7+Commands you ran and the tail of their output. Paste output, not a claim.
8+
9+- Unit tests for the packages touched:
10+- Regression / simulation (required if consensus or state code changed):
11+- Manual check (node, mocknet, replay), if any:
12+
13+## Risk
14+
15+- [ ] Changes consensus, state or funds handling
16+- [ ] Changes Bifrost observation or signing
17+- [ ] Docs, tests or tooling only
18+
19+## Rollout
20+

Ask an AI about this change

Chat assistantClaude, ChatGPT, … (reads a link)

Coding agentClaude Code, Cursor, … (reads the repo)

The context file is context.md. Use Copy with context for an AI that can't open links; it pastes the whole file in.

Glossary

CODEOWNERS
GitLab file mapping paths to the owners whose approval is required. This MR leaves one, at the repository root. CODEOWNERS ↗ GitLab docs ↗
dev-team rule
Project approval rule needing 2 approvals on protected branches, per the MR description; excluded paths stay on it. It isn't in the repo.
Exclusion pattern (!)
A line starting with ! exempts matching paths from the section it sits in. Once excluded, a path can't be re-included there. GitLab docs ↗
huginn-bot
The AI review bot account; listed as one of the eight Core owners.
Section [Core][3]
A named CODEOWNERS section with an approval count; [3] needs three distinct owners from its list. CODEOWNERS ↗